[flang][cuda] Set correct bind(c) name for __popc #152795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-fir-hlfir Author: Valentin Clement (バレンタイン クレメン) (clementval) ChangesThe Full diff: https://github.com/llvm/llvm-project/pull/152795.diff 2 Files Affected:
diff --git a/flang/module/cudadevice.f90 b/flang/module/cudadevice.f90
index d0c312c09353f..dc72fc52c7345 100644
--- a/flang/module/cudadevice.f90
+++ b/flang/module/cudadevice.f90
@@ -754,11 +754,11 @@ attributes(device) real(8) function sinpi(x) bind(c,name='__nv_sinpi')
end interface
interface __popc
- attributes(device) integer function __popc(i) bind(c)
+ attributes(device) integer function __popc(i) bind(c, name='__nv_popc')
!dir$ ignore_tkr (d) i
integer, value :: i
end function
- attributes(device) integer function __popcll(i) bind(c)
+ attributes(device) integer function __popcll(i) bind(c, name='__nv_popcll')
!dir$ ignore_tkr (d) i
integer(8), value :: i
end function
diff --git a/flang/test/Lower/CUDA/cuda-device-proc.cuf b/flang/test/Lower/CUDA/cuda-device-proc.cuf
index d5e614a83b354..a8cc5034a9348 100644
--- a/flang/test/Lower/CUDA/cuda-device-proc.cuf
+++ b/flang/test/Lower/CUDA/cuda-device-proc.cuf
@@ -11,6 +11,7 @@ attributes(global) subroutine devsub()
integer(8) :: al
integer(8) :: time
integer :: smalltime
+ integer(4) :: res
call syncthreads()
call syncwarp(1)
@@ -49,6 +50,9 @@ attributes(global) subroutine devsub()
smalltime = clock()
time = clock64()
time = globalTimer()
+
+ res = __popc(ai)
+ res = __popc(al)
end
! CHECK-LABEL: func.func @_QPdevsub() attributes {cuf.proc_attr = #cuf.cuda_proc<global>}
@@ -89,6 +93,9 @@ end
! CHECK: %{{.*}} = nvvm.read.ptx.sreg.clock64 : i64
! CHECK: %{{.*}} = nvvm.read.ptx.sreg.globaltimer : i64
+! CHECK: %{{.*}} = fir.call @__nv_popc(%{{.*}}) proc_attrs<bind_c> fastmath<contract> : (i32) -> i32
+! CHECK: %{{.*}} = fir.call @__nv_popcll(%{{.*}}) proc_attrs<bind_c> fastmath<contract> : (i64) -> i32
+
subroutine host1()
integer, device :: a(32)
integer, device :: ret
|
vzakhari
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__popcinterface is used to call lib device functions__nv_popcand__nv_popcll. Update the module with the correct bind(c) name